clang-tidy replaces integer literals that are cast to bool.

-header-filter=.*\\.h -checks=-*,modernize-use-bool-literals -fix

diff --git a/jeeps/gpslibusb.cc b/jeeps/gpslibusb.cc
index 04de63af991784826bc42d95afb58f33f1589ccb..f0fa63bf5b28fde106dbdb4b0555760dc06b0bfc 100644 (file)
--- a/jeeps/gpslibusb.cc
+++ b/jeeps/gpslibusb.cc
@@ -231,7 +231,7 @@ gusb_reset_toggles(void)
   gusb_cmd_send((const garmin_usb_packet*) oinit, sizeof(oinit));
 
   t = 10;
-  while (1) {
+  while (true) {
     le_write16(&iresp.gusb_pkt.pkt_id, 0);
     le_write32(&iresp.gusb_pkt.datasz, 0);
     le_write32(&iresp.gusb_pkt.databuf, 0);
@@ -256,7 +256,7 @@ gusb_reset_toggles(void)
 
   t = 10;
   gusb_cmd_send((const garmin_usb_packet*) oid, sizeof(oid));
-  while (1) {
+  while (true) {
     le_write16(&iresp.gusb_pkt.pkt_id, 0);
     le_write32(&iresp.gusb_pkt.datasz, 0);
     le_write32(&iresp.gusb_pkt.databuf, 0);

diff --git a/util.cc b/util.cc
index 3d6d93e0d5ba6a900088e1f2fe6a4e3beef6a8be..fec26db50e2d18935e807f93b05ac56128397e6d 100644 (file)
--- a/util.cc
+++ b/util.cc
@@ -1741,16 +1741,16 @@ entitize(const char* str, bool is_html)
 
 char* xml_entitize(const char* str)
 {
-  return entitize(str, 0);
+  return entitize(str, false);
 }
 
 char* html_entitize(const char* str)
 {
-  return entitize(str, 1);
+  return entitize(str, true);
 }
 char* html_entitize(const QString& str)
 {
-  return entitize(CSTR(str), 1);
+  return entitize(CSTR(str), true);
 }
 
 /*

diff --git a/xcsv.cc b/xcsv.cc
index 583f51d1c0b2cfd6b4c4824802b893cab5457485..6b259810c25eccc86b402d2dbcad1d47d63d3cbb 100644 (file)
--- a/xcsv.cc
+++ b/xcsv.cc
@@ -513,7 +513,7 @@ void
 xcsv_read_internal_style(const char* style_buf)
 {
   xcsv_file_init();
-  xcsv_file.is_internal = 1;
+  xcsv_file.is_internal = true;
 
   xcsv_parse_style_buff(style_buf);